Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MediaType for "application/geo+json". #3243

Closed
wants to merge 1 commit into from

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Aug 17, 2018

GeoJSON Format has been standardized in August 2016 as https://tools.ietf.org/html/rfc7946. This PR adds a MediaType.GEO_JSON constant.

@WilliamCollishaw
Copy link
Contributor

Consider adding @since NEXT in the new constants javadoc for if this gets approved.
Also merge conflict
😄

@simon04
Copy link
Contributor Author

simon04 commented May 21, 2019

I'll consider amending the Javadoc and resolving the merge conflict once it's clear whether this PR will have the chance to be merged. There wasn't a merge conflict in 2018-08, and I haven't gotten a reply/comment since. To me it doesn't make sense to contribute to FOSS when PRs are ignored for months and eventually discarded (cf. my bad experience in googleapis/google-http-java-client#314).

@jbduncan
Copy link
Contributor

@simon04 The Guava team (or the Google Java Libraries team in general) seem to be very busy and struggle to follow up on issues and PRs (I don't know about the Google HTTP Java Client team), so perhaps Guava isn't the best project to contribute to.

I don't know if there's a respective library in Apache Commons (Apache Commons IO, perhaps?), but in my experience they're more prompt than the Guava team, so you may have better luck contributing this MediaType or equivalent to Apache Commons than Guava.

I hope this helps. :)

@kluever kluever self-assigned this May 22, 2019
@kluever
Copy link
Member

kluever commented May 22, 2019

I have a CL out for this internally. Once it gets submitted, it'll get mirrored out shortly there after. Thanks!

@ronshapiro ronshapiro mentioned this pull request May 28, 2019
ronshapiro pushed a commit that referenced this pull request May 28, 2019
via #3243

RELNOTES=Add MediaType for "application/geo+json".

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249531547
ronshapiro pushed a commit that referenced this pull request May 28, 2019
via #3243

RELNOTES=Add MediaType for "application/geo+json".

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249531547
@WilliamCollishaw
Copy link
Contributor

This can be closed

@kluever kluever closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants