Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define project build source encoding as UTF-8 #3465

Conversation

WilliamCollishaw
Copy link
Contributor

@WilliamCollishaw WilliamCollishaw commented May 9, 2019

At build time the following warning appears:
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!

Defining a project build source encoding removes the warning and can prevent platform dependent issues in the future.

Fix summary by maven here and here

@ronshapiro
Copy link
Contributor

Thanks for all of the fixes!

@ronshapiro ronshapiro self-assigned this May 20, 2019
@ronshapiro ronshapiro mentioned this pull request May 28, 2019
ronshapiro pushed a commit that referenced this pull request May 28, 2019
Closes #3465

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249112040
ronshapiro pushed a commit that referenced this pull request May 28, 2019
Closes #3465

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249112040
@WilliamCollishaw WilliamCollishaw deleted the define-build-source-encoding branch May 28, 2019 15:43
@WilliamCollishaw WilliamCollishaw restored the define-build-source-encoding branch June 6, 2019 16:22
@WilliamCollishaw WilliamCollishaw deleted the define-build-source-encoding branch June 6, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants