Upgrade Maven Javadoc Plugin from 3.0.1 to 3.1.0 #3478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally added wildcard syntax to the list of excluded package names due to failing without it after the upgrade
netdpb
added
P2
platform=java11
status=triaged
type=enhancement
|
Cool. Merging internally. |
|
Yes, thank you! |
|
Cool |
Merged
ronshapiro
pushed a commit
that referenced
this pull request
May 28, 2019
Fixes #3478. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=249642506
ronshapiro
pushed a commit
that referenced
this pull request
May 28, 2019
Fixes #3478. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=249642506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated PR from #3476
Upgrade Maven Javadoc Plugin from 3.0.1 to 3.1.0
Additionally added wildcard syntax to the list of excluded package names due to failing without it after the upgrade
Comment from @njhill in PR #3370 notes a javadoc plugin issue with JDK 11 that should be resolved in this most recent version.
The functionality as described in the excludePackageNames documentation does not work as explained which did previously work in 3.0.1. I raised MJAVADOC-605, which duplicated MJAVADOC-584 explaining the issue and have included a work around for the issue which significantly increased the size of the excludePackageNames list.