RFC1123 Compliant InternetDomainName Test Cases #3482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to prove URLs with a leading digit is valid and contains only digits is valid
WilliamCollishaw
changed the title
…omainName-Test-Cases
|
LGTM +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC1123 compliant InternetDomainName test cases
Add tests to prove URLs with leading digits are valid and containing only digits are valid.
#1872 was resolved at some point from 2014 to now without the issue getting closed. This PR adds test cases proving this issue can be closed.
Some sample real domains from related to these tests would be www.9gag.com and www.9292.nl