LocalCache clean up #3492
Closed
LocalCache clean up #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two redundant if statements Removed some unused imports Comment grammar fixes
|
I don‘t really get the point of these changes. To me it seems that this was just the IDE showing up warnings tbh and that it was fixed without really considering if it makes it easier to read or not |
|
I appreciate raising this PR. In the particular circumstances here, I think we'll keep the if conditions as is, as their current structure makes the conditions they intend to check more clear. I will fix the typo for 'accommodate' you raised though, thanks! |
cgdecker
pushed a commit
that referenced
this pull request
Jun 11, 2019
As raised in #3492 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=251860172
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two redundant if statements
Removed some unused imports
Comment grammar fixes