Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #3635

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Moe Sync #3635

merged 5 commits into from
Oct 2, 2019

Conversation

cpovirk
Copy link
Member

@cpovirk cpovirk commented Oct 2, 2019

This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.

Commits:

Check the array indexes in Quantiles.ScaleAndIndexes is non empty.

Fixes #3210
Fixes #3211

823a432


Simplify some code.

Fixes #3580

e2362de


Document the JDK 9+ alternative to `Iterators#forEnumeration`

Fixes #3382

e432be5


Add a MIME type MPEG-DASH (mpd files)

Fixes #2677

RELNOTES=net: Added the MediaType constant for MPEG-DASH.

579ccf6


Fix the logic that decides whether to use currentRequestThreadFactory() under App Engine.

While there, also support thread renaming under App Engine.

Fixes #3598
Relevant to #3606
(also, the CL in which I experimented with #3569 before backing it out)

7bd4b23

NhatDinh and others added 5 commits October 2, 2019 12:11
Fixes #3210
Fixes #3211

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272435318
Fixes #3580

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272440567
Fixes #3382

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272441426
Fixes #2677

RELNOTES=`net`: Added the `MediaType` constant for MPEG-DASH.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272444649
…() under App Engine.

While there, also support thread renaming under App Engine.

Fixes #3598
Relevant to #3606
(also, the CL in which I experimented with #3569 before backing it out)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272446666
@cpovirk cpovirk added the internal-sync A PR that represents a push from Google's internal repo label Oct 2, 2019
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@cpovirk
Copy link
Member Author

cpovirk commented Oct 2, 2019

All non-Googler contributions are taken from PRs.

@cpovirk cpovirk merged commit e3ee00d into master Oct 2, 2019
@cpovirk cpovirk deleted the sync-master-2019/10/02 branch October 2, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes internal-sync A PR that represents a push from Google's internal repo
Projects
None yet
5 participants