Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #3637

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Moe Sync #3637

merged 4 commits into from
Oct 2, 2019

Conversation

cpovirk
Copy link
Member

@cpovirk cpovirk commented Oct 2, 2019

This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.

Commits:

Bump version, which went out of date since the previous CL was created.

90f4a1c


Use if statement instead of for statement for a single item.

Fixes #3633

020621e


Upgrade maven source plugin from 2.1.2 to 3.1.0

Fixes #3466

e87b880


Document the JDK 9+ alternative to `MoreObjects#firstNonNull`

Fixes #3383

145da12

cpovirk and others added 4 commits October 2, 2019 17:06
RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272478122
Fixes #3633

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272503429
Fixes #3466

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272506067
Fixes #3383

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272511395
@cpovirk cpovirk added the internal-sync A PR that represents a push from Google's internal repo label Oct 2, 2019
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cpovirk cpovirk merged commit 7fdf1a6 into master Oct 2, 2019
@cpovirk cpovirk deleted the sync-master-2019/10/02 branch October 2, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no internal-sync A PR that represents a push from Google's internal repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants