Rewrite and publish Throwables.testLazyStackTraceFallback.
#7536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Previously it used a security manager to forbid access to the `sun.misc` APIs and thus force the use of the fallback logic. It also had some Google-internal logic that meant it couldn't be published. Now it uses a custom `ClassLoader` to achieve the same effect more portably. The code path tested here is mostly obsolete. It is really only relevant for JDK 8, so not on Android and not on any later JDK version. RELNOTES=n/a PiperOrigin-RevId: 703567939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite and publish
Throwables.testLazyStackTraceFallback.Previously it used a security manager to forbid access to the
sun.miscAPIs and thus force the use of the fallback logic. It also had some Google-internal logic that meant it couldn't be published. Now it uses a customClassLoaderto achieve the same effect more portably.The code path tested here is mostly obsolete. It is really only relevant for JDK 8, so not on Android and not on any later JDK version.
RELNOTES=n/a