Address some https://errorprone.info/bugpattern/UnnecessaryJavacSuppressWarnings warnings. #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…essWarnings warnings. (And push a few class-level suppressions down to individual methods.) I reverted some of the changes that Error Prone suggested. I'm a little unclear on various things: - whether attempting to suppress `removal` warnings accomplishes anything under any compiler that we care about - whether extending a deprecated type produces a warning under any compiler that we care about - whether some deprecation warnings are showing up as "unnecessary" only because of builds against other sources of `java.*` classes that don't include the JDK's deprecations Hopefully all the removals that I've kept in the CL are good. RELNOTES=n/a PiperOrigin-RevId: 712957106
copybara-service
bot
force-pushed
the
test_712887662
branch
from
aafe318 to
12bf71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some https://errorprone.info/bugpattern/UnnecessaryJavacSuppressWarnings warnings.
(And push a few class-level suppressions down to individual methods.)
I reverted some of the changes that Error Prone suggested. I'm a little unclear on various things:
removalwarnings accomplishes anything under any compiler that we care aboutjava.*classes that don't include the JDK's deprecationsHopefully all the removals that I've kept in the CL are good.
RELNOTES=n/a