Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.22-runtime-tests failures #11338

Open
milantracy opened this issue Jan 5, 2025 · 1 comment
Open

go1.22-runtime-tests failures #11338

milantracy opened this issue Jan 5, 2025 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@milantracy
Copy link
Contributor

Description

runtime tests failed, for example https://buildkite.com/gvisor/pipeline/builds/34118

##### Testing packages.
--
  | # go tool dist test -run=^container/ring$
  | ok  	container/ring	0.038s
  | 2025/01/04 12:05:09 Proctor checking in 2025-01-04 12:05:09.3513882 +0000 UTC m=+90.005853862
  | 2025/01/04 12:05:24 Proctor checking in 2025-01-04 12:05:24.351979646 +0000 UTC m=+105.006445286
  | --- FAIL: TestVerifyConnection (0.02s)
  | --- FAIL: TestVerifyConnection/TLSv12 (0.01s)
  | handshake_client_test.go:1784: RequireAndVerifyClientCert-FullHandshake: handshake failed: remote error: tls: bad certificate
  | --- FAIL: TestVerifyConnection/TLSv13 (0.01s)
  | handshake_client_test.go:1784: RequireAndVerifyClientCert-FullHandshake: handshake failed: remote error: tls: bad certificate
  | --- FAIL: TestResumptionKeepsOCSPAndSCT (0.01s)
  | --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv12 (0.00s)
  | handshake_client_test.go:2575: handshake failed: remote error: tls: bad certificate
  | --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv13 (0.00s)
  | handshake_client_test.go:2575: handshake failed: remote error: tls: bad certificate
  | --- FAIL: TestCrossVersionResume (0.01s)
  | --- FAIL: TestCrossVersionResume/TLSv12 (0.01s)
  | handshake_server_test.go:507: handshake did not resume at the same version
  | --- FAIL: TestCrossVersionResume/TLSv13 (0.01s)
  | handshake_server_test.go:507: handshake did not resume at the same version
  | FAIL
  | FAIL	crypto/tls	1.532s

Steps to reproduce

No response

runsc version

HEAD

docker version (if using docker)

uname

No response

kubectl (if using Kubernetes)

repo state (if built from source)

No response

runsc debug logs (if available)

runtime tests only
@milantracy milantracy added the type: bug Something isn't working label Jan 5, 2025
@milantracy milantracy self-assigned this Jan 5, 2025
@milantracy
Copy link
Contributor Author

i did some investigation to rule out gVisor regression.

Then I found golang/go#71077, which should be the fix

We shall wait for go1.22 and potentially go1.23 backports

I think we shall just refresh our image once they are ready

copybara-service bot pushed a commit that referenced this issue Jan 5, 2025
This test is broken in Go 1.22 as per golang/go#71077.

Fixes #11338

PiperOrigin-RevId: 712237566
copybara-service bot pushed a commit that referenced this issue Jan 6, 2025
This test is broken in Go 1.22 as per golang/go#71077.

Updates #11338

PiperOrigin-RevId: 712237566
copybara-service bot pushed a commit that referenced this issue Jan 6, 2025
This test is broken in Go 1.22 as per golang/go#71077.

Updates #11338

PiperOrigin-RevId: 712237566
copybara-service bot pushed a commit that referenced this issue Jan 6, 2025
This test is broken in Go 1.22 as per golang/go#71077.

Updates #11338

PiperOrigin-RevId: 712398784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant