fix typo in mount setup for initial userns fallback #11333
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
- this fixes an invalid reference to the `goferToHostRPC.OpenMount` method in the urpc client, which leads to consistent errors like `FATAL ERROR: error setting up FS: opening <dir name>: unknown method`. The struct is called `goferToHostRPC`, not `goferRPC` - this bug is always hit when the current process does *not* have permissions to access the mount - this bug was introduced in this recently merged PR: #11128, which added this fallback mechanism FUTURE_COPYBARA_INTEGRATE_REVIEW=#11333 from benhurdelhey:ben-hurdelhey_data/fix-mount-setup-initial-userns-fallback ffb7334 PiperOrigin-RevId: 711765562
|
thanks @ayushr2! Seems like the build pipeline is failing, are these unrelated errors? |
|
Yeah seems unrelated, we will attempt submit again. |
|
@ayushr2 seems like it's still not merged, could you take another look? |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
- this fixes an invalid reference to the `goferToHostRPC.OpenMount` method in the urpc client, which leads to consistent errors like `FATAL ERROR: error setting up FS: opening <dir name>: unknown method`. The struct is called `goferToHostRPC`, not `goferRPC` - this bug is always hit when the current process does *not* have permissions to access the mount - this bug was introduced in this recently merged PR: #11128, which added this fallback mechanism FUTURE_COPYBARA_INTEGRATE_REVIEW=#11333 from benhurdelhey:ben-hurdelhey_data/fix-mount-setup-initial-userns-fallback ffb7334 PiperOrigin-RevId: 711765562
|
@ayushr2 shall we trigger copybara for this PR again? Thank you so much! |
I saw it was just triggered. No need to reply thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goferToHostRPC.OpenMountmethod in the urpc client, which leads to consistent errors likeFATAL ERROR: error setting up FS: opening <dir name>: unknown method. The struct is calledgoferToHostRPC, notgoferRPC