Show type for ErrUnsupportedPtrType #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msabramo
force-pushed
the
show-type-for-ErrUnsupportedPtrType
branch
2 times, most recently
from
53b4bd0 to
bdac9a4
Compare
|
This will definitely conflict with #99 from @slemgrim, which is a much bigger change. I think it makes sense for that one to be merged first and then I can rebase this. |
msabramo
force-pushed
the
show-type-for-ErrUnsupportedPtrType
branch
from
bdac9a4 to
c0336d5
Compare
This may aid in figuring out where the problematic JSON is Before: ``` Pointer type in struct is not supported ``` After: ``` Pointer (*int) in struct is not supported ```
E.g.: ``` [jsonapi unmarshalNode]: Can't unmarshal map[min_containers:2 max_containers:5] () to struct field `Scaling`, which is a pointer to `Scaling` (struct), which is not a supported type ```
msabramo
force-pushed
the
show-type-for-ErrUnsupportedPtrType
branch
from
c0336d5 to
2259d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may aid in figuring out where the problematic JSON is
Before:
After: