This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Add docker-compose integration test #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: we need to either pick docker as the db or the local mysql db engine. |
|
@gdbelvin Ok |
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
+ Coverage 30.23% 30.26% +0.02%
==========================================
Files 48 48
Lines 3873 3873
==========================================
+ Hits 1171 1172 +1
+ Misses 2520 2519 -1
Partials 182 182
Continue to review full report at Codecov.
|
|
Test appears to be failing on Travis. |
* master: (95 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
RJPercival
reviewed
Jul 18, 2019
* master: Cache go mod download (google#1325) Extract log tracking into separate package (google#1317)
* master: Limit the number of map revisions to return at once (google#1326)
RJPercival
approved these changes
Jul 19, 2019
scripts/integration.sh
Outdated
| wget -t 60 --spider --retry-connrefused --waitretry=1 0.0.0.0:443 || sleep 2 | ||
| wget -t 60 --spider --retry-on-http-error=404 1 0.0.0.0:443/v1/directories/default | ||
| wget -T 60 --spider --retry-connrefused localhost:443 | ||
| wget -T 60 --spider --retry-on-http-error=404 --no-check-certificate https://localhost/v1/directories/default |
There was a problem hiding this comment.
Are you sure you don't want to fail the script here if you can't get a 200 response? It seems it'd make it easier to tell what went wrong. Is it just because you've found it to be a bit unreliable?
gdbelvin
force-pushed
the
test
branch
2 times, most recently
from
abd0d0c to
1dcd9bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we don't run across issues in the
cmddirectory due to not actually running things!Fixes #1209