Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Spanner Deployment #1561

Merged
merged 12 commits into from
Jul 3, 2020
Merged

Spanner Deployment #1561

merged 12 commits into from
Jul 3, 2020

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jun 11, 2020

Key Transparency, working on Google Cloud Spanner with Trillian

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1561 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   69.35%   69.60%   +0.25%     
==========================================
  Files          59       59              
  Lines        4385     4385              
==========================================
+ Hits         3041     3052      +11     
+ Misses        910      900      -10     
+ Partials      434      433       -1     
Impacted Files Coverage Δ
core/adminserver/admin_server.go 62.50% <100.00%> (ø)
core/sequencer/server.go 74.18% <0.00%> (+0.65%) ⬆️
core/sequencer/election/tracker.go 80.45% <0.00%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700000d...d4adaff. Read the comment docs.

@gdbelvin gdbelvin marked this pull request as ready for review July 2, 2020 11:05
@gdbelvin gdbelvin requested a review from a team as a code owner July 2, 2020 11:05
@gdbelvin gdbelvin requested review from NatalieDoduc and removed request for a team July 2, 2020 11:05
@gdbelvin
Copy link
Contributor Author

gdbelvin commented Jul 2, 2020

TODO:

  • Pin Trillian docker image?
  • Release Trillian
  • Update go.mod

@gdbelvin gdbelvin merged commit 74d4671 into google:master Jul 3, 2020
@gdbelvin gdbelvin deleted the gke branch July 3, 2020 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants