Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.3] Distribution Commit Build Fail #1422

Closed
Zodiase opened this issue Aug 18, 2015 · 5 comments
Closed

[1.0.3] Distribution Commit Build Fail #1422

Zodiase opened this issue Aug 18, 2015 · 5 comments
Assignees
Milestone

Comments

@Zodiase
Copy link
Contributor

Zodiase commented Aug 18, 2015

Trying to build from commit: 9bfbb76 throws:

Error: Cannot find module './utils/uniffe.js'

as gulpfile.js:27:14 is requiring this file not included in the branch.

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

Or am I not supposed to build from the release branch?

@tleunen
Copy link
Contributor

tleunen commented Aug 18, 2015

I think the release branch is just there to deliver files, not for building stuff

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

@tleunen
Then there's this confusion about which branch should I be monitoring for updating my apps/packages which use custom builds of MDL.
Also, if this is not for building, then why include the src files and the gulpfile, right?

Things in this branch are "official", so I think I should watch this branch, but I can't build from this branch, so when I see a new commit in this branch, I go to the master and pull from there?

@surma
Copy link
Contributor

surma commented Aug 18, 2015

@Zodiase @tleunen Release branch is supposed to be able to produce a build with the provided gulp file. We just missed to add the new files introduced in #1365 to that branch. We’ll fix that in 1.0.4 that will hopefully be released in the next few days.

@tleunen
Copy link
Contributor

tleunen commented Aug 18, 2015

One more reason to simplify all this :D

@addyosmani addyosmani modified the milestone: 1.0.4 Aug 19, 2015
@surma surma self-assigned this Aug 19, 2015
surma added a commit that referenced this issue Aug 19, 2015
Add missing files to release folder (fixes #1422)
@surma surma closed this as completed in 0770c7e Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants