New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to C++17 #12

Open

2 of 6 tasks

ochafik opened this issue Dec 6, 2024 · 0 comments

Collaborator

ochafik commented Dec 6, 2024 •

edited

Loading

llama.cpp just adopted it, and that's also what gemma.cpp uses.

Some options:

Retire nonstd_make_unique backfill
Destructure pairs
std::optional for attempted parsing
std::variant for Value?
More elegant function / filter definitions (leverage new auto inference)
(in the process, optionally make the dep to json a bit looser to be able to switch to json.cpp)

ochafik added a commit that referenced this issue


          First batch of c++11 -> c++17 cosmetic changes (#12)

340db7a

ochafik mentioned this issue

Upgrade c++11 -> c++17 #13

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment