Simplify ninja's environment file handling in build_mozc.py
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparation to build Mozc for ARM64 in Windows (google#1130), this commit aims to simplify UpdateEnvironmentFilesForWindows in build_mozc.py so that we can tweak environment file for ARM64 build configurations in a subsequent commit easily. This is still a mechanical code clean up. There must be no difference in the final artifacts.
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a preparation to build Mozc for ARM64 in Windows, this commit aims to simplify
UpdateEnvironmentFilesForWindowsinbuild_mozc.pyso that we can tweak environment file for ARM64 build configurations in a subsequent commit easily.This is still a mechanical code clean up. There must be no difference in the final artifacts.
Issue IDs
Steps to test new behaviors (if any)
Mozc64.msiwith GYP.