Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added support for quota objects as stated in #238.
One thing to note: I have implemented this object type in a way that aligns with the existing implementation approach of counter object that is already implemented in this lib. It might be good to reconsider the existing implementation approach since object data can be specified as references to existing expression structs implemented in
expr
package and the expression data marshal logic could be reused. At the moment this requires careful rewrite of larger parts of code (expr.Any
interface where marshaling of the object should be separated from marshaling of the complete expression andnftables.Obj
interface implementation at the very least) and seems a bit complex since it easily breaks backwards compatibility. Current implementation should work for the time being.Let me know what you think.