Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible RNN design for comment. #185

Closed
wants to merge 25 commits into from

Conversation

aterzis-google
Copy link
Collaborator

Alternative RNN design due to david-berthelot@

@david-berthelot
Copy link
Contributor

Following on the feedback on the original RNN pull request #97 Andreas and I did a pair-programming session to prototype a better design with the following goals:

  • flexible (accommodate any kind of internal primitive)
  • does not explicitly refers to a batch size
  • does not make decisions for inference (e.g. there are too many cases to provide a solution: like feeding previous prediction, beam search, ...)

Not being an expert myself in recurrent network, I would really love feedback @ebrevdo @AlexeyKurakin - feel free to loop in more people whose opinions could help.

@ebrevdo
Copy link

ebrevdo commented Dec 17, 2020 via email

@aterzis-google
Copy link
Collaborator Author

See #211 instead

@aterzis-google
Copy link
Collaborator Author

Instead, see: #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could you outline how to write a simplest RNN Module?
3 participants