-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible RNN design for comment. #185
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on the feedback on the original RNN pull request #97 Andreas and I did a pair-programming session to prototype a better design with the following goals:
Not being an expert myself in recurrent network, I would really love feedback @ebrevdo @AlexeyKurakin - feel free to loop in more people whose opinions could help. |
Some rough thoughts:
1. There will always be some RNNs that will want to do something across
batch and time. These will be some combination of scan + input/output
layers that can handle the time dimension (e.g., Dense layer). So expect
that users will still subclass/override RNN. LSTM is a good example.
2. get_initial_state is still super useful. why? there are RNNs whose
state is a nested combination of tensors including tensors of different
*types*. for example, some special RNNs have as the state an integer
scalar corresponding to the current time step. so each iteration of the
RNN increments that state by one. but the other states are typical
floating point vectors.
…On Thu, Dec 17, 2020 at 1:19 PM David Berthelot ***@***.***> wrote:
Following on the feedback on the original RNN pull request #97
<#97> Andreas and I did a
pair-programming session to prototype a better design with the following
goals:
- flexible (accommodate any kind of internal primitive)
- does not explicitly refers to a batch size
- does not make decisions for inference (e.g. there are too many cases
to provide a solution: like feeding previous prediction, beam search, ...)
Not being an expert myself in recurrent network, I would really love
feedback @ebrevdo <https://github.com/ebrevdo> @AlexeyKurakin
<https://github.com/AlexeyKurakin> - feel free to loop in more people
whose opinions could help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#185 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWFG4XEXERYH3TDFGX7FLSVJYUVANCNFSM4VACK3FQ>
.
|
c3ad751
to
74271d6
Compare
See #211 instead |
Instead, see: #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative RNN design due to david-berthelot@