[infra] Fix dataflow engine compilation for a runtime speed up (#1632). #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Dor1s, TravisBuddy Request Identifier: 610c3380-33dd-11ea-b5a3-65565334105f |
Dor1s
commented
Jan 12, 2020
|
This broke three projects which are still using
|
LebedevRI
added a commit
to LebedevRI/oss-fuzz
that referenced
this pull request
Sep 5, 2020
… up (google#1632). (google#3219)" Relying on the fact that `LIB_FUZZING_ENGINE` will not be escaped and will be interpreted as a glob by the build system seems counter-intuitive, and actively prevented RawSpeed dataflow config from just work. This partially reverts commit cbdc655.
conor42
pushed a commit
to conor42/fxz
that referenced
this pull request
Dec 28, 2021
google/oss-fuzz#3219 (comment) Thanks to Bhargava Shastry for sending the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in llvm/llvm-project@679669a, and besides the speedup, it seems like tracing didn't work on OSS-Fuzz since then. Maybe it stopped working some time later, but it definitely doesn't work right now.
Also added a bad build check for the current existing interface.