Adds concurrency to hydration requests #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Mar 17, 2023
pkg/osv/osv.go
Outdated
| go func(resp *BatchedResponse) { | ||
| for batchIdx, response := range resp.Results { | ||
| for resultIdx, vuln := range response.Vulns { | ||
| rateLimiter <- struct{}{} |
There was a problem hiding this comment.
nit: can we use https://pkg.go.dev/golang.org/x/sync/semaphore#example-package-WorkerPool instead?
There was a problem hiding this comment.
I did see that package, but since semaphores are under the /x/ experimental package I'm not sure whether we should use it.
There was a problem hiding this comment.
Should be fair game to use it. There's a lot of prominent packages using it already: https://deps.dev/go/golang.org%2Fx%2Fsync/v0.1.0/dependents
|
Not any issue in particular, I just realized the sequential calls are a major part of the run time when looking at implementing #303 . |
oliverchang
approved these changes
Mar 20, 2023
|
@another-rex are we ready to merge? |
G-Rath
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at concurrency for hydration requests. I'm not sure if this is the most concise way to do so, it seems pretty long for what should be a simple concurrency logic.