net-test: packetdrill: update tcp/epoll tests to latest kernel behavior #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EPOLLOUT tests expect a buggy kernel behavior where EPOLLOUT is not sent in some circumstances, when only a small fragment is acknowledged. Kernel commit 4bfe744ff164 "tcp: fix potential xmit stalls caused by TCP_NOTSENT_LOWAT" changes the kernel behavior in that regard and fixes the bug. Adapt the EPOLLOUT tests to match the new/correct kernel behavior. The epoll_out_edge.pkt and epoll_out_edge_default_notsent_lowat.pkt tests require an additional change because the last write is a full write now. Instead of changing the write size to make it a partial write again, keep the write size unchanged and adjust the expected result of epoll_wait(), since partial writes are already tested earlier in the test flow. Signed-off-by: Radu Rendec <[email protected]> Change-Id: I7327d88fd1280f115ebf4f2a3c83ae4ff590d117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EPOLLOUT tests expect a buggy kernel behavior where EPOLLOUT is not sent in some circumstances, when only a small fragment is acknowledged. Kernel commit 4bfe744ff164 "tcp: fix potential xmit stalls caused by TCP_NOTSENT_LOWAT" changes the kernel behavior in that regard and fixes the bug.
Adapt the EPOLLOUT tests to match the new/correct kernel behavior.
The epoll_out_edge.pkt and epoll_out_edge_default_notsent_lowat.pkt tests require an additional change because the last write is a full write now. Instead of changing the write size to make it a partial write again, keep the write size unchanged and adjust the expected result of epoll_wait(), since partial writes are already tested earlier in the test flow.