Bail out fast when no demangling is requested #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid trying to demangle functions one by one; besides, `demangleSingleFunction` doesn't quite behave correctly when **no** demangling is requested.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
+ Coverage 66.86% 66.94% +0.07%
==========================================
Files 44 44
Lines 9824 9859 +35
==========================================
+ Hits 6569 6600 +31
- Misses 2794 2820 +26
+ Partials 461 439 -22 ☔ View full report in Codecov by Sentry. |
aalexand
reviewed
Dec 6, 2024
internal/symbolizer/symbolizer.go
Outdated
| @@ -257,6 +257,10 @@ func Demangle(prof *profile.Profile, force bool, demanglerMode string) { | |||
| } | |||
|
|
|||
| options := demanglerModeToOptions(demanglerMode) | |||
| // bail out fast to avoid any parsing, if we really don't want any demangling. | |||
There was a problem hiding this comment.
nit: bail -> Bail
https://google.github.io/styleguide/go/decisions#comment-sentences
aalexand
previously approved these changes
Dec 6, 2024
aalexand
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid trying to demangle functions one by one; besides,
demangleSingleFunctiondoesn't quite behave correctly when no demangling is requested.