Use per-edition feature defaults instead of syntax type to control behavior. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to take a look, @agrue, here is the next change. |
agrue
reviewed
Oct 2, 2024
proto-lens-protoc/app/Data/ProtoLens/Compiler/Editions/Features.hs
Outdated
Show resolved
Hide resolved
agrue
approved these changes
Oct 2, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically replaces
SyntaxTypedistinguishing between proto2 and proto3 withFeatureSetcontrolling individual features in Protobuf Editions. For example, instead of checking whether the syntax is proto3 when determining whether repeated fields should use packed encoding by default, we check whetherfeatures.repeated_field_encodingisPACKED. The default feature set compatible with proto2 and proto3 are provided byprotocand included inData.ProtoLens.Compiler.Defaults. The existing tests continue to pass, showing that the features have been determined correctly.This does not complete support for Protobuf Editions. This requires the ability to override options in certain scopes, e.g., file scope or field scope, which will be added in https://github.com/chungyc/proto-lens/pull/8.
This is the second to last change required for #468.