Plugin is not compatible with changes in Kotlin Gradle plugins 1.9.0 release #714
Comments
Tapchicoma
changed the title
Tapchicoma
added a commit
to Tapchicoma/protobuf-gradle-plugin
that referenced
this issue
Jul 7, 2023
Kotlin Gradle Plugin 1.9.0 release has changed how kapt tasks are configured: https://youtrack.jetbrains.com/issue/KT-54468/KAPT-Gradle-plugin-causes-eager-task-creation. Because of this change, generated proto sources are not passed to kaptGenerateStubs task leading to compilation error even in default setup. If the Kotlin plugin version is 1.7.20 - protobuf plugin now, instead of directly configuring KotlinCompile task inputs, configures related KotlinSourceSet. This way additional sources are passed both for KotlinCompile and KaptGenerateStubs tasks. Fixes issue google#714
ejona86
pushed a commit
that referenced
this issue
Jul 10, 2023
Kotlin Gradle Plugin 1.9.0 release has changed how kapt tasks are configured: https://youtrack.jetbrains.com/issue/KT-54468/KAPT-Gradle-plugin-causes-eager-task-creation. Because of this change, generated proto sources are not passed to kaptGenerateStubs task leading to compilation error even in default setup. If the Kotlin plugin version is 1.7.20 - protobuf plugin now, instead of directly configuring KotlinCompile task inputs, configures related KotlinSourceSet. This way additional sources are passed both for KotlinCompile and KaptGenerateStubs tasks. Fixes issue #714
|
Fixed by #715 |
YifeiZhuang
pushed a commit
to YifeiZhuang/protobuf-gradle-plugin
that referenced
this issue
Jul 13, 2023
…gle#715) Kotlin Gradle Plugin 1.9.0 release has changed how kapt tasks are configured: https://youtrack.jetbrains.com/issue/KT-54468/KAPT-Gradle-plugin-causes-eager-task-creation. Because of this change, generated proto sources are not passed to kaptGenerateStubs task leading to compilation error even in default setup. If the Kotlin plugin version is 1.7.20 - protobuf plugin now, instead of directly configuring KotlinCompile task inputs, configures related KotlinSourceSet. This way additional sources are passed both for KotlinCompile and KaptGenerateStubs tasks. Fixes issue google#714
YifeiZhuang
added a commit
that referenced
this issue
Jul 13, 2023
… (#721) Kotlin Gradle Plugin 1.9.0 release has changed how kapt tasks are configured: https://youtrack.jetbrains.com/issue/KT-54468/KAPT-Gradle-plugin-causes-eager-task-creation. Because of this change, generated proto sources are not passed to kaptGenerateStubs task leading to compilation error even in default setup. If the Kotlin plugin version is 1.7.20 - protobuf plugin now, instead of directly configuring KotlinCompile task inputs, configures related KotlinSourceSet. This way additional sources are passed both for KotlinCompile and KaptGenerateStubs tasks. Fixes issue #714 Co-authored-by: Yahor Berdnikau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the Kotlin 1.9.0 release, kapt tasks should now be additionally configured with the same custom configuration as
KotlinCompiletask.Here protobuf plugin configures
KotlinJvmCompiletasks with additional generated sources. Now it should also configureKaptGenerateStubstask with this additional sources. Even better approach would be to configure releatedKotlinSourceSetsimilar to this workaround:androidComponents.beforeVariants { android.sourceSets.register(it.name) { java.srcDir(buildDir.resolve("generated/source/proto/${it.name}/java")) kotlin.srcDir(buildDir.resolve("generated/source/proto/${it.name}/kotlin")) } }The text was updated successfully, but these errors were encountered: