Integrate with kotlin gradle plugin #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Dec 20, 2017
| @@ -59,6 +60,23 @@ class ProtobufPlugin implements Plugin<Project> { | |||
| 'android-library', | |||
| ] | |||
|
|
|||
| private static final String USER_LANG_PROP = 'protobuf_gradle_plugin_additional_languages' | |||
There was a problem hiding this comment.
gRPC use lower camelcase for its project property names. A quick search on the internet also shows such pattern:
http://mrhaki.blogspot.com/2016/05/gradle-goodness-get-property-or-default.html
We should probably follow.
| javaCompileTask.dependsOn(generateProtoTask) | ||
| generateProtoTask.getAllOutputDirs().each { dir -> | ||
| javaCompileTask.source project.fileTree([dir:dir]) | ||
| project.sourceSets.each { SourceSet sourceSet -> |
There was a problem hiding this comment.
Do you have plan to add support for Android projects?
There was a problem hiding this comment.
Yes, I have a PR that's ready to be posted after this one is merged.
zhangkun83
approved these changes
Dec 20, 2017
|
any plans for this to get released? Is there a snapshot version available that can/should be used? |
|
Since #208 is now resolved, I think we can release what we have on master branch @zhangkun83 |
zhangkun83
pushed a commit
to zhangkun83/protobuf-gradle-plugin-1
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to be generic wrt language build tasks, and specifically tests against kotlin. If users want to enable additional unsupported languages, they can set the project property
protobuf_gradle_plugin_additional_languagesas aList<String>of more languages.Test projects are now created programmatically by repeatedly copying overlay directories into a temp directory.
Updated tests and examples:
This only tests a plain kotlin project. A follow up PR will address Android.