Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gradle.plugin from coordinates for recent release #571

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

ejona86
Copy link
Collaborator

@ejona86 ejona86 commented Jun 29, 2022

5eade53 inadvertently changed the coordinates used for the plugin from
gradle.plugin.com.google.protobuf:protobuf-gradle-plugin to
com.google.protobuf:protobuf-gradle-plugin. This is because simply
adding the maven-publish plugin changes plugin-publish's behavior
(gradle/plugin-portal-requests#124).

Although this was accidental, this does seem to be the way things are
supposed to work going forward as later versions of the plugin-publish
than we are using always include maven-publish and the
mavenCoordinates override block was removed
https://plugins.gradle.org/plugin/com.gradle.plugin-publish/1.0.0 .

5eade53 inadvertently changed the coordinates used for the plugin from
gradle.plugin.com.google.protobuf:protobuf-gradle-plugin to
com.google.protobuf:protobuf-gradle-plugin. This is because simply
adding the maven-publish plugin changes plugin-publish's behavior
(gradle/plugin-portal-requests#124).

Although this was accidental, this does seem to be the way things are
supposed to work going forward as later versions of the plugin-publish
than we are using always include maven-publish and the
`mavenCoordinates` override block was removed
https://plugins.gradle.org/plugin/com.gradle.plugin-publish/1.0.0 .
@ejona86 ejona86 requested a review from YifeiZhuang June 29, 2022 19:38
Copy link
Collaborator

@YifeiZhuang YifeiZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you put a wrong commit in the description?
c9576b6 should be the cause.

Since we use this group, and mavenCoordinates block is gone, does it mean you will need approval for publishing the plugin because not starting with gradle.plugin?

@ejona86
Copy link
Collaborator Author

ejona86 commented Jun 30, 2022

No, c9576b6 was correct and accurate. Compare the classpath suggested:
https://plugins.gradle.org/plugin/com.google.protobuf/0.8.18
https://plugins.gradle.org/plugin/com.google.protobuf/0.8.19

It actually changed. I tracked it down to the mere presence of maven-publish changing the behavior of plugin-publish.

does it mean you will need approval for publishing the plugin because not starting with gradle.plugin?

In Maven Central (which we can probably stop publishing for new versions sometime soon) the coordinate didn't change. So there's no issue there.

In plugins.gradle.org I discovered this issue only because 0.8.19 required approval. It wasn't at all obvious why it required approval, but I found that thread on plugin-portal-requests which seemed to be a very similar situation. And then the approval didn't take too long so I was able to verify that, yes, the coordinates changed on plugins.gradle.org. That won't be a problem for future releases though.

@ejona86 ejona86 mentioned this pull request Jul 1, 2022
@ejona86 ejona86 requested a review from YifeiZhuang July 1, 2022 23:15
@ejona86 ejona86 merged commit bbba8c1 into google:master Jul 6, 2022
@ejona86 ejona86 deleted the coordinate-change branch July 6, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants