Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ToolsLocator stop using Configuration#fileCollection(Dependency...), soon to be deprecated #716

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

YifeiZhuang
Copy link
Collaborator

fix #708

@YifeiZhuang YifeiZhuang requested a review from ejona86 July 7, 2023 21:47
@YifeiZhuang YifeiZhuang merged commit a80bf81 into master Jul 7, 2023
@YifeiZhuang YifeiZhuang deleted the deprecate-configureation-file-filter branch July 7, 2023 22:15
YifeiZhuang added a commit to YifeiZhuang/protobuf-gradle-plugin that referenced this pull request Jul 13, 2023
… soon to be deprecated (google#716)

The files(Dependency...) method filters the contents of the configuration to only include files from the provided dependencies and it's transitive dependencies. Since there is only one dependency in the configuration, using this method is unnecessary.
YifeiZhuang added a commit that referenced this pull request Jul 13, 2023
… soon to be deprecated (#716) (#720)

The files(Dependency...) method filters the contents of the configuration to only include files from the provided dependencies and it's transitive dependencies. Since there is only one dependency in the configuration, using this method is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf plugin uses Configuration#fileCollection(Dependency...) method
2 participants