Skip to content

Commit

Permalink
Minor fix in query_bench set_nested_value benchmark: (#630)
Browse files Browse the repository at this point in the history
`rebuild` shallow clones the message and returns an updated message, so
return value should be used.

Thanks to @sigurdm for noticing this.
  • Loading branch information
osa1 authored Apr 25, 2022
1 parent 767ce81 commit 5731242
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion query_benchmark/bin/set_nested_value.dart
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ main() {
title: 'protobuf_decode',
duration: measure(() => a.rebuild((f0.A0 a0Builder) {
a0Builder.a4.last = a0Builder.a4.last.rebuild((f2.A1 a1builder) {
a1builder.a378.rebuild(
a1builder.a378 = a1builder.a378.rebuild(
(f19.A220 a220builder) => a220builder.a234 = 'new_value');
});
})),

0 comments on commit 5731242

Please sign in to comment.