Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error #3208 #3204 #3211

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fixed error #3208 #3204 #3211

merged 1 commit into from
Mar 12, 2021

Conversation

surajkumar-sk
Copy link
Contributor

@surajkumar-sk surajkumar-sk commented Mar 12, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Module named io is imported and io.open() is used instead of open() for fixing encoding error which occurs in python2 .
added encoding type as utf-8 in line 251 for fixing UnicodeDecodeError
Fixes # (issue)
#3208
#3204

Screenshots (optional)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • New and existing unit tests pass locally with my changes

@joeyparrish
Copy link
Member

Running tests on our CI system now. Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit ee14514 into shaka-project:master Mar 12, 2021
@joeyparrish
Copy link
Member

Congratulations! And thank you for your contributions. We're very glad to have your help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants