Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes encoding error #3208

Closed
wants to merge 1 commit into from
Closed

fixes encoding error #3208

wants to merge 1 commit into from

Conversation

tanish14
Copy link

fixes #3204

Added encoding='utf8' to the arguments of open() which no longer shows an error and works fine

@shaka-bot
Copy link
Collaborator

Test Failure:

Traceback (most recent call last):
TypeError: 'encoding' is an invalid keyword argument for this function
Build step 'Execute shell' marked build as failure

@joeyparrish
Copy link
Member

Looks like you'll need to make sure it works in both python2 and python3. Thanks!

@surajkumar-sk
Copy link
Contributor

surajkumar-sk commented Mar 12, 2021

Hi , I am participating in GSOC 2021 . I would love to work on Shaka player for this gsoc . I am trying to understand this project .
When i try to compile the library i get this issue #3204 . tanish14 has given a perfect solution which works for python 3 but fails on python 2. for dealing with encoding files in python2, io.open() should be used . open() works perfectly in python3 for dealing with encoding files but not in python2 . i would like to PR the changes combining @tanish14 and my changes .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
4 participants