This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add par_test variant of par_binary, passthrough testonly attr #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to run py_tests as .par files, which is occasionally useful for testing code that behaves differently when called from within a zipped executable. It also enables the uncommon (but valid) scenario of having a par_binary definition with testonly=True set.
|
Thanks for this merge request! It'll take me a couple of days to review this, due to some other issues that I'm working on right now. We'll want to add some sample par_test targets to the tests/ subdirectory as well. |
|
Sorry, still trying to deal with some other Bazel breakages. |
duggelz
approved these changes
Aug 8, 2017
|
awesome, thank you :-) |
|
Thanks for your pull request, merged. I have to do some refactoring to address Bazel changes, so I'll add tests for this at the same time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to run py_tests as .par files, which is occasionally useful for testing code that behaves differently when called from within a zipped executable. It also enables the uncommon (but valid, I'm pretty sure) scenario of having a par_binary definition with
testonly=Trueset.