This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fixes for --all_incompatible_changes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(x-ref bazelbuild/bazel#7308 and bazelbuild/bazel#7347) |
|
The equivalent of a diffbase is using a new branch for every PR. I don't believe GH has a way to deal with chained PRs other than doing them as PR reviews within a fork before finally merging them all to the main dest repo? |
gpshead
approved these changes
Mar 7, 2019
This is a one-liner to rename `default_python_version` for a `py_binary` target. This does not rename the corresponding attribute on the `parfile` rule. That attribute is currently marked mandatory, though it doesn't appear to be used. If we want to keep it, and if we want a gentle migration period, we'd need to introduce a new `python_version` attribute for `parfile`, make them both non-mandatory, and validate them at anaylsis time, similarly to how Bazel handled the rename of this attribute for `py_binary`/`py_test`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets
bazel build //... --all_incompatible_changesworking with Bazel 0.23.("Diffbased" on #95, but I don't know what the equivalent of diffbase is in github if any. Just ignore the docgen commit in this PR.)
Edit: To confirm and save you some time, the content of this PR is just 2 changed lines.