Skip to content

Commit

Permalink
Bump golangci-lint from 1.51.1 to 1.55.1 (#3177)
Browse files Browse the repository at this point in the history
  • Loading branch information
roger2hk authored Nov 1, 2023
1 parent dbacbf2 commit 0f63e3a
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
with:
version: 'v1.51.1'
version: 'v1.55.1'
args: ./storage/crdb

unit-test:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## HEAD

* Bump golangci-lint from 1.51.1 to 1.55.1 (developers should update to this version)

## v1.5.3

* Recommended go version for development: 1.20
Expand Down
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ go generate -x ./... # hunts for //go:generate comments and runs them

The Trillian codebase uses go.mod to declare fixed versions of its dependencies.
With Go modules, updating a dependency simply involves running `go get`:
```

```bash
go get package/path # Fetch the latest published version
go get package/[email protected] # Fetch a specific published version
go get package/path@HEAD # Fetch the latest commit
Expand All @@ -203,7 +204,8 @@ Be warned however, that this may undo any selected versions that resolve issues

While running `go build` and `go test`, go will add any ambiguous transitive dependencies to `go.mod`
To clean these up run:
```

```bash
go mod tidy
```

Expand All @@ -213,21 +215,23 @@ The [`scripts/presubmit.sh`](scripts/presubmit.sh) script runs various tools
and tests over the codebase.

#### Install [golangci-lint](https://github.com/golangci/golangci-lint#local-installation).

```bash
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.1
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.1
```

#### Run code generation, build, test and linters

```bash
./scripts/presubmit.sh
```

#### Or just run the linters alone

```bash
golangci-lint run
```


## Design

### Design Overview
Expand Down
2 changes: 1 addition & 1 deletion integration/cloudbuild/testbase/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN apt-get update && apt-get install -y \
xxd

# Install golangci-lint. See docs at: https://golangci-lint.run/usage/install/.
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.51.1
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.55.1

# Install CockroachDB, see https://www.cockroachlabs.com/docs/v22.1/install-cockroachdb-linux
RUN curl https://binaries.cockroachdb.com/cockroach-v22.1.11.linux-amd64.tgz | tar -xz && cp -i cockroach-v22.1.11.linux-amd64/cockroach /usr/local/bin/
Expand Down

0 comments on commit 0f63e3a

Please sign in to comment.