Skip to content

Commit

Permalink
Bump go from 1.19 to 1.20 (#3080)
Browse files Browse the repository at this point in the history
* Bump go from 1.19 to 1.20

The current stable version on https://go.dev/dl/ is 1.21 and we support the last two minor versions. This unblocks part of #3079.

* Fix setup-go checking out go1.2 instead of 1.20
  • Loading branch information
mhutchinson authored Aug 31, 2023
1 parent 0b1f6de commit 4373100
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: 1.19
go-version: '1.20'
check-latest: true
cache: true

- uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
with:
Expand All @@ -35,7 +37,7 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: '1.19'
go-version: '1.20'
check-latest: true
cache: true

Expand All @@ -49,7 +51,7 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: '1.19'
go-version: '1.20'
check-latest: true
cache: true

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## HEAD

* Recommended go version for development: 1.20
* This is the version used by the cloudbuild presubmits. Using a
different version can lead to presubmits failing due to unexpected
diffs.


## v.1.5.2

* Recommended go version for development: 1.19
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The current state of feature implementation is recorded in the

To build and test Trillian you need:

- Go 1.19 or later (go 1.19 matches cloudbuild, and is preferred for developers
- Go 1.20 or later (go 1.20 matches cloudbuild, and is preferred for developers
that will be submitting PRs to this project).

To run many of the tests (and production deployment) you need:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/trillian

go 1.19
go 1.20

require (
bitbucket.org/creachadair/shell v0.0.7
Expand Down

0 comments on commit 4373100

Please sign in to comment.