Skip to content

Commit

Permalink
Pin the version of cockroach for tests to a specific version (#2971)
Browse files Browse the repository at this point in the history
./storage/crdb tests have started failing in GCP recently. Investigation shows that this is pulling the latest tagged version, which breaks hermetic builds. This PR is a test to see if using the previous version fixes the issue, and if so, I propose merging this to unblock things and then discussing with the community to look for better solutions.
  • Loading branch information
mhutchinson authored Apr 18, 2023
1 parent 36eecad commit 638f2e0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/crdb/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (db *testDBHandle) GetDB() *sql.DB {
func TestMain(m *testing.M) {
flag.Parse()

ts, err := testserver.NewTestServer()
ts, err := testserver.NewTestServer(testserver.CustomVersionOpt("22.2.7"))
if err != nil {
klog.Exitf("Failed to start test server: %v", err)
}
Expand Down

0 comments on commit 638f2e0

Please sign in to comment.