Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency from certificate-transparency-go #2733

Closed
pav-kv opened this issue May 5, 2022 · 1 comment · Fixed by #2744
Closed

Drop dependency from certificate-transparency-go #2733

pav-kv opened this issue May 5, 2022 · 1 comment · Fixed by #2744
Assignees
Labels

Comments

@pav-kv
Copy link
Contributor

pav-kv commented May 5, 2022

Currently, there is a circular dependency between trillian and certificate-transparency-go modules:

~/go/src/github.com/google/trillian$ go mod graph | grep " github.com/google/certificate-transparency-go"
github.com/google/trillian github.com/google/[email protected]
github.com/google/[email protected] github.com/google/[email protected]
github.com/google/[email protected] github.com/google/[email protected]

In the reverse direction:

~/go/src/github.com/google/certificate-transparency-go$ go mod graph | grep " github.com/google/trillian"
github.com/google/certificate-transparency-go github.com/google/[email protected]
github.com/google/[email protected] github.com/google/[email protected]
github.com/google/[email protected] github.com/google/[email protected]

The only used package from certificate-transparency-go repository is tls serialisation format imported here.

@mhutchinson
Copy link
Contributor

https://go-proverbs.github.io: A little copying is better than a little dependency

Just copy tls into an internal directory inside trillian? :-)

@mhutchinson mhutchinson self-assigned this May 26, 2022
mhutchinson added a commit to mhutchinson/trillian that referenced this issue May 26, 2022
This fixes google#2733

More changes than I'd like to go.{mod,sum} as a result of `go mod tidy`.
mhutchinson added a commit that referenced this issue May 27, 2022
This fixes #2733, though I needed to add tls to linter exclusions as it's copied in from a repo with different lint rules.

More changes than I'd like to go.{mod,sum} as a result of `go mod tidy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants