Unexport HashLogRoot. Verify with VerifySignedLogRoot. #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbelvin
force-pushed
the
f/sig/logroot_proto
branch
from
a8c86f7 to
2b97bd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 62.6% 62.56% -0.05%
==========================================
Files 100 101 +1
Lines 8324 8379 +55
==========================================
+ Hits 5211 5242 +31
- Misses 2593 2610 +17
- Partials 520 527 +7
Continue to review full report at Codecov.
|
SignLogRoot should produce a *trillian.SignedLogRoot VerifyLogRoot should verify a *trillian.SignedLogRoot This prevents clients from needing to parse the SignedLogRoot object themslves. It also provides a single API point to maintain. VerifySignedLogRoot will produce a *trillian.SignedLogRoot. The idea is the force clients to only use data that has been returned from a successful verification.
gdbelvin
force-pushed
the
f/sig/logroot_proto
branch
from
2b97bd8 to
cc99c97
Compare
daviddrysdale
approved these changes
Mar 8, 2018
crypto/signer.go
Outdated
| // signature. Hashing is performed by github.com/benlaurie/objecthash. | ||
| func (s *Signer) SignLogRoot(root *trillian.SignedLogRoot) (*sigpb.DigitallySigned, error) { | ||
| hash, err := HashLogRoot(*root) | ||
| // SignLogRoot hashes and signs the supplied (to-be) SignedLogRoot and returns a SignedLogRoot |
There was a problem hiding this comment.
Maybe "returns a complete SignedLogRoot (including signature)".
(also nit) Trailing full stop in comment.
crypto/signer_test.go
Outdated
| @@ -115,23 +115,17 @@ func TestSignLogRoot(t *testing.T) { | |||
| t.Errorf("Failed to sign log root: %v", err) | |||
| continue | |||
| } | |||
| if got := len(sig.Signature); got == 0 { | |||
| if got := len(sig.Signature.Signature); got == 0 { | |||
There was a problem hiding this comment.
sig is now a bit misleading - maybe rename to slr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the API surface of the crypto package: unexport
HashLogRootSigning and verifying
SignedLogRoots should only go throughSignLogRootandVerifySignedLogRootfunctions. This simplifies future work to adjust the signature formats.#958