-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LogRootV1 with SignLogRoot / VerifyLogRoot #1048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 62.69% 62.66% -0.03%
==========================================
Files 103 103
Lines 8408 8413 +5
==========================================
+ Hits 5271 5272 +1
- Misses 2610 2613 +3
- Partials 527 528 +1
Continue to review full report at Codecov.
|
This doesn't seem to have affected many tests. Is that OK? They are mostly internal changes I suppose. |
You might know better than me, but it seems to me like it's hitting the right number of tests. |
Yes there's a lot of mock signer usage and nothing much is using the signatures at the moment. It's probably OK. |
LGTM? |
Following google/trillian#1048, use types.LogRootV1 as the local reference of what the most up-to-date log root is.
Following google/trillian#1048, use types.LogRootV1 as the local reference of what the most up-to-date log root is.
Following google/trillian#1048, use types.LogRootV1 as the local reference of what the most up-to-date log root is.
This PR continues in the theme of #958 by using the
LogRootV1
defined in #1037 to create*trillian.SignedLogRoot
objects viaSignLogRoot
. Verifying a*trillian.SignedLogRoot
will also extract and return theLogRootV1
object.Local references to
trillian.SignedLogRoot
that access it's fields will slowly be replaced withLogRootV1
objects.Note that
LogID
is no longer a part ofLogRootV1
. In future PRs,LogID
will be more related to thesigner
than theLogRootV1
object.