Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogRootV1 with SignLogRoot / VerifyLogRoot #1048

Merged
merged 2 commits into from
Mar 13, 2018

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Mar 9, 2018

This PR continues in the theme of #958 by using the LogRootV1 defined in #1037 to create *trillian.SignedLogRoot objects via SignLogRoot. Verifying a *trillian.SignedLogRoot will also extract and return the LogRootV1 object.

Local references to trillian.SignedLogRoot that access it's fields will slowly be replaced with LogRootV1 objects.

Note that LogID is no longer a part of LogRootV1. In future PRs, LogID will be more related to the signer than the LogRootV1 object.

@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #1048 into master will decrease coverage by 0.02%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   62.69%   62.66%   -0.03%     
==========================================
  Files         103      103              
  Lines        8408     8413       +5     
==========================================
+ Hits         5271     5272       +1     
- Misses       2610     2613       +3     
- Partials      527      528       +1
Impacted Files Coverage Δ
server/log_rpc_server.go 77.46% <100%> (-0.21%) ⬇️
crypto/verifier.go 50.94% <100%> (+5.11%) ⬆️
storage/tools/dump_tree/dumplib/dumplib.go 41.94% <100%> (-0.22%) ⬇️
crypto/signer.go 74.46% <100%> (+2.37%) ⬆️
log/sequencer.go 79.27% <100%> (-0.19%) ⬇️
client/log_verifier.go 73.58% <78.57%> (+0.5%) ⬆️
client/log_client.go 70% <88.88%> (-1.07%) ⬇️
util/tracker.go 96.61% <0%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16362da...08cbb5f. Read the comment docs.

@Martin2112
Copy link
Contributor

This doesn't seem to have affected many tests. Is that OK? They are mostly internal changes I suppose.

@gdbelvin
Copy link
Contributor Author

You might know better than me, but it seems to me like it's hitting the right number of tests.
Many of our tests mock out the signing bits don't they?

@Martin2112
Copy link
Contributor

Yes there's a lot of mock signer usage and nothing much is using the signatures at the moment. It's probably OK.

@gdbelvin
Copy link
Contributor Author

LGTM?

@gdbelvin gdbelvin merged commit 0d98af7 into google:master Mar 13, 2018
@gdbelvin gdbelvin deleted the f/sig/logroot_sign_root branch March 13, 2018 13:41
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 14, 2018
Following google/trillian#1048, use types.LogRootV1 as the local
reference of what the most up-to-date log root is.
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 15, 2018
Following google/trillian#1048, use types.LogRootV1 as the local
reference of what the most up-to-date log root is.
gdbelvin added a commit to google/keytransparency that referenced this pull request Mar 15, 2018
Following google/trillian#1048, use types.LogRootV1 as the local
reference of what the most up-to-date log root is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants