Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tests for types package #1070

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Better tests for types package #1070

merged 2 commits into from
Mar 26, 2018

Conversation

gdbelvin
Copy link
Contributor

Add checks for decoding to a nil ptr and invalid type lengths.

Cherry picked the orthogonal changes to types out of #1037.

@gdbelvin gdbelvin requested a review from daviddrysdale March 26, 2018 14:33
@gdbelvin gdbelvin changed the title Types package cleanup Better tests for types package Mar 26, 2018
@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #1070 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1070      +/-   ##
=========================================
+ Coverage   62.08%   62.1%   +0.01%     
=========================================
  Files         104     104              
  Lines        8553    8557       +4     
=========================================
+ Hits         5310    5314       +4     
  Misses       2703    2703              
  Partials      540     540
Impacted Files Coverage Δ
types/logroot.go 93.33% <100%> (+0.47%) ⬆️
types/maproot.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734f47a...fc3ce73. Read the comment docs.

@gdbelvin gdbelvin merged commit facffc9 into google:master Mar 26, 2018
@gdbelvin gdbelvin deleted the types branch March 26, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants