-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for 1.0.9 #1089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=======================================
Coverage 61.89% 61.89%
=======================================
Files 103 103
Lines 8626 8626
=======================================
Hits 5339 5339
Misses 2728 2728
Partials 559 559 Continue to review full report at Codecov.
|
|
||
Published 2018-04-17 07:01:46 +0000 UTC | ||
|
||
Changes are in progress (e.g. see PR #1037) to rework the internal signed root format used by the log RPC server to be more useful / interoperable. Currently they are mostly internal API changes to the log and map servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the changes are just "internal API changes" -- running git diff v1.0.8.. *proto
gives a lot of (external) API changes, some of which are not obviously back-compatible. Can we summarize the API changes and think about whether they justify a higher-level bump in version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the signature changes most of the others seem to be Maps related or part of implementing preordered logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature
and log_id
fields in SignedLogRoot
have been deleted. If any client code that uses the Trillian gRPC API references those fields, it will fail to compile with this update. From a semver perspective, that would imply that this should be v2.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and adding the SLR to Get*
responses is adding new functionality in back-compatible way, so would imply v1.1.0...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll close this and create a new branch for 1.1.0 then.
|
||
Published 2018-04-17 07:01:46 +0000 UTC | ||
|
||
Changes are in progress (e.g. see PR #1037) to rework the internal signed root format used by the log RPC server to be more useful / interoperable. Currently they are mostly internal API changes to the log and map servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature
and log_id
fields in SignedLogRoot
have been deleted. If any client code that uses the Trillian gRPC API references those fields, it will fail to compile with this update. From a semver perspective, that would imply that this should be v2.0.0.
|
||
Published 2018-04-17 07:01:46 +0000 UTC | ||
|
||
Changes are in progress (e.g. see PR #1037) to rework the internal signed root format used by the log RPC server to be more useful / interoperable. Currently they are mostly internal API changes to the log and map servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #1037 isn't auto linking -- could we make it [#1037](https://github.com/google/trillian/pull/1037)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
The CloudSpanner schema has changed. If you have a database instance you'll need to recreate it with the new schema. Performance has been noticeably improved since the previous release and we have tested it to approx one billion log entries. Note: This code is still being developed and further changes are possible. | ||
|
||
Support for `sqlite` has been removed because of ongoing issues with flaky tests. These were caused by concurrent accesses to the same database, which it doesn't support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Support for sqlite
in unit tests ...." to make it clearer that we've not removed anything important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
No description provided.