added/updated postgresql implementation of log_storage

server/admin/admin_server_test.go

@@ -596,10 +596,10 @@ func TestServer_CreateTree_AllowedTreeTypes(t *testing.T) {
 	for _, test := range tests {
 		setup := setupAdminServer(
 			ctrl,
-			nil,                       /* keygen */
-			false,                     /* snapshot */
-			test.wantCode == codes.OK, /* shouldCommit */
-			false /* commitErr */)
+			nil,   // keygen
+			false, // snapshot
+			test.wantCode == codes.OK,
+			false)
 		s := setup.server
 		tx := setup.tx
 		s.allowedTreeTypes = test.treeTypes
@@ -771,7 +771,7 @@ func TestServer_DeleteTree(t *testing.T) {
 			nil,   /* keygen */
 			false, /* snapshot */
 			true,  /* shouldCommit */
-			false /* commitErr */)
+			false)
 		req := &trillian.DeleteTreeRequest{TreeId: test.tree.TreeId}
 
 		tx := setup.tx
@@ -810,10 +810,10 @@ func TestServer_DeleteTreeErrors(t *testing.T) {
 	for _, test := range tests {
 		setup := setupAdminServer(
 			ctrl,
-			nil,                   /* keygen */
-			false,                 /* snapshot */
-			test.deleteErr == nil, /* shouldCommit */
-			test.commitErr /* commitErr */)
+			nil,
+			false,
+			test.deleteErr == nil,
+			test.commitErr)
 		req := &trillian.DeleteTreeRequest{TreeId: 10}
 
 		tx := setup.tx
@@ -858,7 +858,7 @@ func TestServer_UndeleteTree(t *testing.T) {
 			nil,   /* keygen */
 			false, /* snapshot */
 			true,  /* shouldCommit */
-			false /* commitErr */)
+			false)
 		req := &trillian.UndeleteTreeRequest{TreeId: test.tree.TreeId}
 
 		tx := setup.tx
@@ -897,10 +897,10 @@ func TestServer_UndeleteTreeErrors(t *testing.T) {
 	for _, test := range tests {
 		setup := setupAdminServer(
 			ctrl,
-			nil,                     /* keygen */
-			false,                   /* snapshot */
-			test.undeleteErr == nil, /* shouldCommit */
-			test.commitErr /* commitErr */)
+			nil,
+			false,
+			test.undeleteErr == nil,
+			test.commitErr)
 		req := &trillian.UndeleteTreeRequest{TreeId: 10}
 
 		tx := setup.tx

server/postgres_storage_provider.go

@@ -66,7 +66,9 @@ func newPGProvider(mf monitoring.MetricFactory) (StorageProvider, error) {
 }
 
 func (s *pgProvider) LogStorage() storage.LogStorage {
-	panic("Not Implemented")
+
+	glog.Warningf("Support for the PostgreSQL log is experimental.  Please use at your own risk!!!")
+	return postgres.NewLogStorage(s.db, s.mf)
 }
 
 func (s *pgProvider) MapStorage() storage.MapStorage {

storage/postgres/README.md

@@ -0,0 +1,17 @@
+# Postgres LogStorage
+
+## Notes and Caveats
+The current LogStorage part of the Postgres implementation was based off what
+was already written for MySQL.  Thus, the two user-defined functions included in 
+storage.sql.  MySQL doesn't kill a transaction when a duplicate is detected, but 
+PostgreSQL does.  So, to preserve the workflow, I included the two functions 
+which trap this error and allow the code to continue executing.  The only other
+change I made was to fully translate the MySQL queries to PostgreSQL compatible ones
+and tidy up some of the extant tree storage code.
+
+storage_unsafe.sql really isn't unsafe, but I have pulled some of the safety
+rails from the tables to improve performance.  It also works under the notion that
+there will only be a single tree in a given database.  An improvement on this theme 
+would be to add all layers below the trees table in their own separate schemas.  
+This would further eliminate indexs and foreign key requirements, but it should
+be left for those who require enhanced performance.  Storage.sql should be fine for most applications

storage/postgres/admin_storage_test.go

@@ -29,6 +29,7 @@ import (
 )
 
 var allTables = []string{"unsequenced", "tree_head", "sequenced_leaf_data", "leaf_data", "subtree", "tree_control", "trees"}
+var db *sql.DB
 
 const selectTreeControlByID = "SELECT signing_enabled, sequencing_enabled, sequence_interval_seconds FROM tree_control WHERE tree_id = $1"