Make MaskLeft of NodeID return an explicit copy. #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're copying everything twice as do n.Copy().MaskLeft().
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
- Coverage 67.21% 67.15% -0.06%
==========================================
Files 110 110
Lines 8950 8952 +2
==========================================
- Hits 6016 6012 -4
- Misses 2334 2340 +6
Partials 600 600
Continue to review full report at Codecov.
|
AlCutter
approved these changes
May 17, 2019
gdbelvin
added a commit
that referenced
this pull request
May 23, 2019
* master: (94 commits) Complete TODO (#1632) fake_node_reader: Remove unused field (#1631) Parallelize VerifyMapLeavesResponse (#1615) Remove redundant root hash calculations (#1630) sequencer: Consolidate compact.Tree initialization (#1629) Remove unused NodeReader method (#1625) Fix bazel build (#1627) added/updated postgresql implementation of log_storage (#1571) Clean up compact.Tree tests (#1622) Remove old hash list format from compact.Tree (#1621) Mention protoc-gen-doc in README.md merkle: Add testonly package with golden hashes (#1620) compact: Simplify getting hashes in NewTreeWithState (#1618) compact: Implement Tree using Range (#1522) Guard verbose logging in merkle path code (#1604) Make MaskLeft of NodeID return an explicit copy. (#1612) Convert directly from Int.Bits() to NodeID (#1614) Couple of changes to make NodeIDs more frugal. (#1613) compact.Tree: Change semantic of adding leaves (#1592) MapHasher: Do not return error from HashLeaf (#1611) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're copying everything twice as we do
n.Copy().MaskLeft()everywhere.Checklist