Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move server binaries to /cmd directory #2027

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Move server binaries to /cmd directory #2027

merged 2 commits into from
Jan 16, 2020

Conversation

RJPercival
Copy link
Contributor

@RJPercival RJPercival commented Jan 16, 2020 •
edited
Loading

Also moves /server/main.go to /cmd/server, because this part of the "server" package is fairly specific to those binaries.

Checklist

@RJPercival RJPercival self-assigned this Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #2027 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
+ Coverage   58.25%   58.81%   +0.55%     
==========================================
  Files         117      116       -1     
  Lines        9880     9784      -96     
==========================================
- Hits         5756     5754       -2     
+ Misses       3620     3526      -94     
  Partials      504      504
Impacted Files Coverage Δ
log/operation_manager.go 86.97% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07600f...b3dd5ab. Read the comment docs.

@RJPercival RJPercival removed their assignment Jan 16, 2020
gdbelvin
gdbelvin suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few more paths need updating

Move server binaries to /cmd directory
440e0ac 
Also moves /server/main.go to /cmd/internal/serverutil, because this part
of the "server" package is fairly specific to those binaries.
@RJPercival RJPercival requested a review from gdbelvin January 16, 2020 16:40
gdbelvin
gdbelvin approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for being the first one to try out the internal directory!

@RJPercival RJPercival added this to the Trillian v2 milestone Jan 16, 2020
@RJPercival RJPercival merged commit 44b7cab into google:master Jan 16, 2020
@RJPercival RJPercival deleted the move_servers branch January 16, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdbelvin gdbelvin gdbelvin approved these changes

@mhutchinson mhutchinson Awaiting requested review from mhutchinson

Assignees

@gdbelvin gdbelvin

Labels
cla: yes
Projects
None yet
Milestone
Trillian v2
Development

Successfully merging this pull request may close these issues.
3 participants
@RJPercival @gdbelvin @googlebot