Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Move flag out of the package to main.go #2287

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Jan 21, 2021

Move the flag so that it is always initialised after storage providers are imported.

$ go run main.go --help
...
  -storage_system string
        Storage system to use. One of: [cloud_spanner mysql] (default "mysql")
...

Similar to issue #2026.

Checklist

@pav-kv pav-kv requested a review from AlCutter January 21, 2021 19:09
@pav-kv pav-kv requested a review from a team as a code owner January 21, 2021 19:09
@pav-kv pav-kv requested a review from Martin2112 January 21, 2021 19:15
@pav-kv
Copy link
Contributor Author

pav-kv commented Jan 22, 2021

PTAL

@AlCutter
Copy link
Member

storage/provider_test.go:80:8: undefined: providers

@pav-kv
Copy link
Contributor Author

pav-kv commented Jan 22, 2021

Fixed the tests

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #2287 (f53436d) into master (219fef4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2287   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files         118      118           
  Lines        8903     8902    -1     
=======================================
  Hits         5787     5787           
+ Misses       2456     2455    -1     
  Partials      660      660           
Impacted Files Coverage Δ
storage/provider.go 88.88% <ø> (+4.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219fef4...f53436d. Read the comment docs.

@pav-kv pav-kv merged commit 85d73fd into google:master Jan 22, 2021
@pav-kv pav-kv deleted the fix_storage_flag branch January 22, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants