storage: Use compact.NodeID #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
force-pushed
the
use_compact_node_id
branch
2 times, most recently
from
6288fa7 to
e2e35b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2395 +/- ##
==========================================
+ Coverage 65.76% 65.77% +0.01%
==========================================
Files 107 107
Lines 7758 7749 -9
==========================================
- Hits 5102 5097 -5
+ Misses 2122 2120 -2
+ Partials 534 532 -2
Continue to review full report at Codecov.
|
Martin2112
approved these changes
Mar 11, 2021
| return nodes, nil | ||
| } | ||
|
|
||
| // TODO(pavelkalinnikov): Allow nodes to be out of order. | ||
| func nodesAreEqual(lhs []stree.Node, rhs []stree.Node) error { | ||
| func nodesAreEqual(lhs, rhs []stree.Node) error { |
There was a problem hiding this comment.
Can we replace this with some variant of cmp.Diff? That did't exist when this was written + same for func below.
There was a problem hiding this comment.
The plan is to significantly refactor/simplify SubtreeCache anyway, so I will likely revisit/delete this bit in follow-up PRs.
pav-kv
force-pushed
the
use_compact_node_id
branch
from
e2e35b2 to
0417598
Compare
pav-kv
force-pushed
the
use_compact_node_id
branch
from
0417598 to
29a7425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
NodeIDtype is very complex. This change replaces it withthe simple
compact.NodeIDfrom the application layer all the way downto
SubtreeCache, but the latter still uses the old type. In follow-upchanges it will be removed completely.
Part of #2378.
Checklist