Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Remove unused convert package #2397

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Mar 11, 2021

Part of #2378

@pav-kv pav-kv requested a review from NatalieDoduc March 11, 2021 22:37
@pav-kv pav-kv requested a review from a team as a code owner March 11, 2021 22:37
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2397 (c381a0b) into master (fa9aa84) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   65.78%   65.59%   -0.20%     
==========================================
  Files         107      106       -1     
  Lines        7749     7708      -41     
==========================================
- Hits         5098     5056      -42     
- Misses       2119     2120       +1     
  Partials      532      532              
Impacted Files Coverage Δ
client/log_client.go 70.93% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9aa84...c381a0b. Read the comment docs.

Copy link
Contributor

@NatalieDoduc NatalieDoduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the cleanup.

Would you mind adding the link to the context issue in the commit description? Thanks.

(nice detailed issue description, BTW)

@pav-kv
Copy link
Contributor Author

pav-kv commented Mar 12, 2021

@NatalieDoduc What link do you mean? If you mean link this PR from the issue, it's done automatically when the issue number is mentioned in comment/description.

@pav-kv pav-kv merged commit 88ed3bf into google:master Mar 12, 2021
@pav-kv pav-kv deleted the rm_storagepb_convert branch March 12, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants