-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NodeID2 in map hasher #2401
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
==========================================
+ Coverage 65.56% 65.60% +0.03%
==========================================
Files 106 106
Lines 7702 7696 -6
==========================================
- Hits 5050 5049 -1
+ Misses 2120 2116 -4
+ Partials 532 531 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This does shine a light on github.com/google/trillian/storage/tree
being a weird package; storage
doesn't feel like something that should be on the API for clients to be leaning on.
My other concern with this is that this will need importing into trillian-examples
and seeing what delta it causes for the maps there. However, that isn't going to happen until the pending update (google/trillian-examples#257) is applied, so I guess this will fall on me to maintain.
|
This includes google/trillian#2401 which changes the usage of NodeID2, and thus requires some changes to the examples here to stay in sync.
This includes google/trillian#2401 which changes the usage of NodeID2, and thus requires some changes to the examples here to stay in sync.
MapHasher
is the penultimate user of theNodeID
type, which is beingremoved soon. Since the maps are deprecated/experimental, we are free to
change the hasher interface to use a better
NodeID2
type.Part of #2378.