Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert compact.NodeID to Suffix directly #2402

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Mar 13, 2021

This change removes indirection in conversion from compact.NodeID to Suffix.
This further reduces the amount of things depending on tree.NodeID.

Part of #2378.

@pav-kv pav-kv requested review from pphaneuf and Martin2112 March 13, 2021 02:20
@pav-kv pav-kv requested a review from a team as a code owner March 13, 2021 02:20
@google-cla google-cla bot added the cla: yes label Mar 13, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #2402 (62d3d45) into master (74e8305) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
+ Coverage   65.56%   65.62%   +0.05%     
==========================================
  Files         106      106              
  Lines        7702     7700       -2     
==========================================
+ Hits         5050     5053       +3     
+ Misses       2120     2115       -5     
  Partials      532      532              
Impacted Files Coverage Δ
storage/cache/log_tile.go 63.15% <75.00%> (-1.85%) ⬇️
client/log_client.go 71.51% <0.00%> (+0.58%) ⬆️
log/operation_manager.go 89.41% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e8305...62d3d45. Read the comment docs.

@pav-kv pav-kv force-pushed the convert_to_suffix branch from 85dc187 to 9ee2417 Compare March 13, 2021 02:36
@pav-kv pav-kv force-pushed the convert_to_suffix branch from 9ee2417 to 62d3d45 Compare March 13, 2021 02:38
@pav-kv pav-kv merged commit 0750ec1 into google:master Mar 15, 2021
@pav-kv pav-kv deleted the convert_to_suffix branch March 15, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants