Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused KeyHint field. #2442

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Remove the unused KeyHint field. #2442

merged 3 commits into from
Apr 6, 2021

Conversation

pphaneuf
Copy link
Contributor

@pphaneuf pphaneuf commented Apr 1, 2021

Reviewing commit by commit might be easier.

Checklist

@pphaneuf pphaneuf requested a review from pav-kv April 1, 2021 19:58
@pphaneuf pphaneuf requested review from AlCutter, Martin2112 and a team as code owners April 1, 2021 19:58
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2442 (71e498f) into master (6127136) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
- Coverage   66.15%   66.09%   -0.07%     
==========================================
  Files         104      104              
  Lines        7204     7191      -13     
==========================================
- Hits         4766     4753      -13     
  Misses       1924     1924              
  Partials      514      514              
Impacted Files Coverage Δ
storage/cloudspanner/log_storage.go 56.03% <ø> (-0.09%) ⬇️
storage/mysql/log_storage.go 65.87% <ø> (-0.09%) ⬇️
types/logroot.go 100.00% <ø> (ø)
crypto/signer.go 86.95% <100.00%> (-1.05%) ⬇️
trees/trees.go 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6127136...71e498f. Read the comment docs.

@pphaneuf
Copy link
Contributor Author

pphaneuf commented Apr 6, 2021

This PR might be easiest to review commit-by-commit.

trillian.proto Show resolved Hide resolved
@pphaneuf pphaneuf merged commit ce04341 into google:master Apr 6, 2021
@pphaneuf pphaneuf deleted the keyhint branch April 6, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants